Some update for more powerful #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihsuan
reviewed
Apr 3, 2019
package.json
Outdated
| @@ -5,52 +5,76 @@ | |||
| "main": "src/app.ts", | |||
| "scripts": { | |||
| "start": "ts-node -r tsconfig-paths/register src/app.ts --type-check", | |||
| "start:debug": "yarn start --debug", | |||
| "start:runtime": "TS_NODE_PROJECT=tsconfig.runtime.json node -r tsconfig-paths/register -r source-map-support/register build/app", | |||
There was a problem hiding this comment.
Change the name from runtime to prod would be more intuitive. e.g yarn start:prod and tsconfig.prod.json. And note that we should use the pm2 for the production.
There was a problem hiding this comment.
sure, just add README.md.
Please review and give me some feedback~~if any not understand. 😀
chihsuan
reviewed
Apr 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update some packages, and add some useful functions I used in PhotoRoom.
debug mode
yarn start:debugprettier
fix dataloaderMiddleware in many-to-many
add production command
yarn start:runtimeadd S3Service
upgrade packages, such as [email protected], typescript, tslint...
update README