Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add getItemsAtCurrentTime(timeOfEvent) & delay optimization on item click for trackpads #910

Merged
merged 15 commits into from
Apr 28, 2021
Merged

fix: add getItemsAtCurrentTime(timeOfEvent) & delay optimization on item click for trackpads #910

merged 15 commits into from
Apr 28, 2021

Conversation

lidakis
Copy link
Contributor

@lidakis lidakis commented Feb 14, 2021 •
edited
Loading

Thank you for contributing to vis.js!!

Please make sure to check the following requirements before creating a pull request:

  • All pull requests must be to the master branch.
  • Make sure your changes are based on the latest version of the master branch. (Use e.g. git fetch && git rebase origin master to update your feature branch).
  • Provide an additional or update an example to demonstrate your changes or new features.
  • Update the documentation if you introduced new behavior or changed existing behavior.
  • Reference issue numbers of issues that your pull request addresses. (If you write something like fixes #1781 in your git commit message this issue gets closed automatically by merging your pull request).
  • Expect review comments and change requests by reviewer.
  • Delete this checklist from your pull request.

lidakis and others added 6 commits August 21, 2019 18:39
@lidakis
timeline fixes
42311a8 
lidakis several timeline fixes
@lidakis
Update ItemSet.js
0dd4925 
double tap new item disable
@lidakis
Update Core.js
cc1f7a0 
put delay on edit click item...
@lidakis
getItemsAtCurrentTime(timeOfEvent)
20d3309
@lidakis
blablabla
ce301b5
#getItemsAtCurrentTime()
8feaacd
mojoaxel
mojoaxel previously approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to cleanup the pull-request title, description and squash the commits!

@lidakis lidakis changed the title puul req addition of method getItemsAtCurrentRime(timeOfEvent) Mar 18, 2021
@lidakis lidakis changed the title addition of method getItemsAtCurrentRime(timeOfEvent) method addition getItemsAtCurrentRime(timeOfEvent) Mar 18, 2021
@lidakis lidakis requested a review from mojoaxel March 18, 2021 09:23
@lidakis lidakis changed the title method addition getItemsAtCurrentRime(timeOfEvent) method addition getItemsAtCurrentRime(timeOfEvent) & delay addition on item click for trackpads. Mar 18, 2021
lidakis added 4 commits March 18, 2021 11:27
@lidakis
Delay on item click
7d1a6ec 
Delay addition on item click optimised for trackpads, in order to not deselect the item.
@lidakis
getItemsAtCurrentTime(timeOfEvent)
b433a08 
Addition of method getItemsAtCurrentTime(timeOfEvent): Returns {Array} of all items they are present at current time of click event on the timeline.
... addition of delay on item click (optimisation for laptop trackpads) in order not to deselect the item after 1 second when clicked with trackpad.
@lidakis
getItemsAtCurrentTime(timeOfEvent)
82d0b0c 
Addition of method getItemsAtCurrentTime(timeOfEvent): Returns {Array} of all items they are present at current time of click event on the timeline.
... addition of delay on item click (optimisation for laptop trackpads) in order not to deselect the item after 1 second when clicked with trackpad.
@lidakis
Optimize trackpad item click delay.
7852f45 
delay addition on item click for trackpads...
@lidakis lidakis changed the title method addition getItemsAtCurrentRime(timeOfEvent) & delay addition on item click for trackpads. method addition getItemsAtCurrentRime(timeOfEvent) & delay opimization on item click for trackpads. Mar 18, 2021
lidakis
lidakis commented Mar 18, 2021
View reviewed changes
Copy link
Contributor Author

@lidakis lidakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard these changes... at 'blablabla'

@lidakis lidakis changed the title method addition getItemsAtCurrentRime(timeOfEvent) & delay opimization on item click for trackpads. method addition getItemsAtCurrentTime(timeOfEvent) & delay optimization on item click for trackpads. Mar 18, 2021
@yotamberk yotamberk changed the title method addition getItemsAtCurrentTime(timeOfEvent) & delay optimization on item click for trackpads. fix: add getItemsAtCurrentTime(timeOfEvent) & delay optimization on item click for trackpads Apr 13, 2021
@yotamberk yotamberk merged commit a76bf87 into visjs:master Apr 28, 2021
@vis-bot
Copy link
Collaborator

vis-bot commented Apr 28, 2021

🎉 This PR is included in version 7.4.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@polosson polosson mentioned this pull request May 6, 2021
Closed
@0xSebin 0xSebin mentioned this pull request Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamberk yotamberk yotamberk approved these changes

@mojoaxel mojoaxel Awaiting requested review from mojoaxel

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidakis @vis-bot @mojoaxel @yotamberk