Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a is not defined in this example. #226

Merged
merged 3 commits into from
Dec 21, 2019
Merged

fix: a is not defined in this example. #226

merged 3 commits into from
Dec 21, 2019

Conversation

awesomeQiuJH
Copy link
Contributor

@awesomeQiuJH awesomeQiuJH commented Dec 17, 2019 •
edited
Loading

examples/timeline/groups/verticalItemsHide.html has a mistake: 'a is not defined'.

yotamberk
yotamberk requested changes Dec 17, 2019
View reviewed changes
Copy link
Member

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the PR but maybe set a clearer name for the var?

@yotamberk yotamberk merged commit c38a816 into visjs:master Dec 21, 2019
@vis-bot
Copy link
Collaborator

vis-bot commented Dec 21, 2019

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamberk yotamberk yotamberk approved these changes

Assignees

@yotamberk yotamberk

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awesomeQiuJH @vis-bot @yotamberk