Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Select - deselect due to long press too short (configurable) #244

Closed
fras2560 opened this issue Jan 8, 2020 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@fras2560
Copy link
Contributor

fras2560 commented Jan 8, 2020

My company uses the timeline. To give background we have multi-select enabled. Some users are experiencing issues when attempting to drag the timeline. The users will select the item they would like to drag by clicking on the item and then proceed to drag. However, if you click and hold the item it will de-select. This is only an issue when multi-select is enabled (not present otherwise) The duration of the click and hold seems to be 251 ms (believe that it is the default from hammer.js). I think this default is probably fine for most use cases but it would be nice to be able to configure this.

Once can test this by using the basicUsage.html and adding multi-select to it

// Configuration for the Timeline
 var options = {
       multiselect: true,
       editable: {
         add: false,
         updateTime: true,
         updateGroup: false,
         remove: false,
         overrideItems: false,
       },
     };

I tried to look into this myself and adding a option for it but I am not exactly sure about how timeline and hammer interact. Any guidance or advice on this would be appreciated.

@fras2560
Copy link
Contributor Author

fras2560 commented Jan 8, 2020

Opened a PR (#245) for this issue with my attempt at allow for such a feature

@yotamberk yotamberk added the enhancement New feature or request label Jan 12, 2020
@yotamberk
Copy link
Member

Added with #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants