Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting editable.updateGroup: false breaks onUpdate #202

Closed
aaronik opened this issue Nov 22, 2019 · 1 comment · Fixed by #262
Closed

setting editable.updateGroup: false breaks onUpdate #202

aaronik opened this issue Nov 22, 2019 · 1 comment · Fixed by #262
Labels
bug Something isn't working released

Comments

@aaronik
Copy link

aaronik commented Nov 22, 2019

Setting the timeline options eidtable.updateGroup to false does what it is supposed to as I understand it, in that items can no longer be draggable to other groups, which is great. This is exactly the functionality I'm looking for, so I was excited when I found that option.

However, I also need to allow the items to call the onUpdate function when they're double clicked, and it appears that setting editable.updateGroup to false means onUpdate is no longer called.

I have a jsfiddle. You can see that dragging items within a group works fine, and they can't be dragged outside of the group. They also cannot be double clicked (which will alert 'hi').

If you change the updateGroup toggle to true, the supplied onUpdate function will start working again.

Here's the fiddle.

@yotamberk yotamberk added the bug Something isn't working label Nov 22, 2019
robinsonlam pushed a commit to robinsonlam/vis-timeline that referenced this issue Jan 20, 2020
…s#202

Check if both editable options are true instead of one by one
yotamberk added a commit that referenced this issue Jan 21, 2020
…#262)

Check if both editable options are true instead of one by one

Co-authored-by: Yotam Berkowitz <[email protected]>
@vis-bot
Copy link
Collaborator

vis-bot commented Jan 21, 2020

🎉 This issue has been resolved in version 6.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants