use exactly version 5.0.5 of vis-util #1109
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment on #1064, the upstream package
vis-util
has removed the add/remove event listeners API in visjs/vis-util#1417, in version 5.0.6 specifically.This causes errors to be displayed in the console when the user lets go of the mouse button after dragging the graph, including in the official examples.
This PR changes the
package.json
to use exactly 5.0.5 ofvis-util
; the newest version before the removal of the listeners API.With this change,
npm install
unfortunately prints this resolution error:Running
npm install --force
overrides this and allows the installation to complete.After that, doing a build produces a
vis-graph3d.min.js
file that doesn't produce thatUncaught TypeError
anymore.