Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running all tests in a suite before reporting #156

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

evanworley
Copy link

These changes run all the tests in a suite before reporting. Previous the first assertion failure was reported and expresso stopped running tests. I believe it is more useful to report all the failures in the test, to prevent the developer from executing the run/fix loop many times.

@evanworley
Copy link
Author

Added one more fix which addresses an unchecked call to test.callback() in assertResponse. The problem is that test.callback only exists if the Test has multiple tests, otherwise it's null. The bad call to callback generates an exception which results in the http server not being shut down properly.

@evanworley
Copy link
Author

Two more fixes

  1. Allowing nested assert.response by properly decrementing server.__pending
  2. Fixing test failure reporting wrong test when running in parallel

@ericlathrop
Copy link

This would be a big help.

@evanworley
Copy link
Author

Hi Eric,

It appears that expresso is mostly dead. We switched to Mocha (http://visionmedia.github.com/mocha/) a few months ago, and I'd suggest you do the same. Unless you want to maintain expresso :/

  • Evan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants