setup golangci-lint job

.github/workflows/main.yml

@@ -8,6 +8,20 @@ on:
 
 jobs:
 
+  lint:  
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: 1.17
+
+      - uses: golangci/golangci-lint-action@v3
+        with:
+          args: --print-resources-usage --verbose
+
   build:
     runs-on: ubuntu-latest
     steps:

.golangci.yml

@@ -0,0 +1,33 @@
+issues:
+  exclude-rules:
+    - linters:
+        - revive
+      text: var-naming
+  max-issues-per-linter: 0
+  max-same-issues: 0
+
+linters:
+  enable:
+    - gci
+    - gofumpt
+    - gosimple
+    - govet
+    - ineffassign
+    - nilerr
+    - revive
+    - staticcheck
+    - unconvert
+    - whitespace
+  disable:
+    - errcheck
+    - unused
+
+linters-settings:
+  gci:
+    sections:
+      - standard
+      - default
+      - prefix(github.com/vishvananda)
+
+run:
+  timeout: 5m

addr_linux.go

@@ -6,9 +6,10 @@ import (
 	"strings"
 	"syscall"
 
+	"golang.org/x/sys/unix"
+
 	"github.com/vishvananda/netlink/nl"
 	"github.com/vishvananda/netns"
-	"golang.org/x/sys/unix"
 )
 
 // AddrAdd will add an IP address to a link device.
@@ -153,7 +154,7 @@ func (h *Handle) addrHandle(link Link, addr *Addr, req *nl.NetlinkRequest) error
 	// value should be "forever". To compensate for that, only add the attributes if at least one of the values is
 	// non-zero, which means the caller has explicitly set them
 	if addr.ValidLft > 0 || addr.PreferedLft > 0 {
-		cachedata := nl.IfaCacheInfo{unix.IfaCacheinfo{
+		cachedata := nl.IfaCacheInfo{IfaCacheinfo: unix.IfaCacheinfo{
 			Valid:    uint32(addr.ValidLft),
 			Prefered: uint32(addr.PreferedLft),
 		}}
@@ -380,13 +381,13 @@ func addrSubscribeAt(newNs, curNs netns.NsHandle, ch chan<- AddrUpdate, done <-c
 					continue
 				}
 				if m.Header.Type == unix.NLMSG_ERROR {
-					error := int32(native.Uint32(m.Data[0:4]))
-					if error == 0 {
+					errno := int32(native.Uint32(m.Data[0:4]))
+					if errno == 0 {
 						continue
 					}
 					if cberr != nil {
 						cberr(fmt.Errorf("error message: %v",
-							syscall.Errno(-error)))
+							syscall.Errno(-errno)))
 					}
 					continue
 				}
@@ -406,13 +407,15 @@ func addrSubscribeAt(newNs, curNs netns.NsHandle, ch chan<- AddrUpdate, done <-c
 					continue
 				}
 
-				ch <- AddrUpdate{LinkAddress: *addr.IPNet,
+				ch <- AddrUpdate{
+					LinkAddress: *addr.IPNet,
 					LinkIndex:   addr.LinkIndex,
 					NewAddr:     msgType == unix.RTM_NEWADDR,
 					Flags:       addr.Flags,
 					Scope:       addr.Scope,
 					PreferedLft: addr.PreferedLft,
-					ValidLft:    addr.ValidLft}
+					ValidLft:    addr.ValidLft,
+				}
 			}
 		}
 	}()

addr_test.go

@@ -20,15 +20,15 @@ func TestAddrReplace(t *testing.T) {
 	DoTestAddr(t, AddrReplace)
 }
 
-func DoTestAddr(t *testing.T, FunctionUndertest func(Link, *Addr) error) {
+func DoTestAddr(t *testing.T, functionUndertest func(Link, *Addr) error) {
 	if os.Getenv("CI") == "true" {
 		t.Skipf("Fails in CI with: addr_test.go:*: Address flags not set properly, got=128, expected=132")
 	}
 	// TODO: IFA_F_PERMANENT does not seem to be set by default on older kernels?
 	// TODO: IFA_F_OPTIMISTIC failing in CI. should we just skip that one check?
-	var address = &net.IPNet{IP: net.IPv4(127, 0, 0, 2), Mask: net.CIDRMask(32, 32)}
-	var peer = &net.IPNet{IP: net.IPv4(127, 0, 0, 3), Mask: net.CIDRMask(24, 32)}
-	var addrTests = []struct {
+	address := &net.IPNet{IP: net.IPv4(127, 0, 0, 2), Mask: net.CIDRMask(32, 32)}
+	peer := &net.IPNet{IP: net.IPv4(127, 0, 0, 3), Mask: net.CIDRMask(24, 32)}
+	addrTests := []struct {
 		addr     *Addr
 		expected *Addr
 	}{
@@ -67,7 +67,7 @@ func DoTestAddr(t *testing.T, FunctionUndertest func(Link, *Addr) error) {
 	}
 
 	for _, tt := range addrTests {
-		if err = FunctionUndertest(link, tt.addr); err != nil {
+		if err = functionUndertest(link, tt.addr); err != nil {
 			t.Fatal(err)
 		}
 
@@ -138,15 +138,14 @@ func DoTestAddr(t *testing.T, FunctionUndertest func(Link, *Addr) error) {
 			t.Fatal("Address not removed properly")
 		}
 	}
-
 }
 
 func TestAddrAddReplace(t *testing.T) {
 	tearDown := setUpNetlinkTest(t)
 	defer tearDown()
 
-	var address = &net.IPNet{IP: net.IPv4(127, 0, 0, 2), Mask: net.CIDRMask(24, 32)}
-	var addr = &Addr{IPNet: address}
+	address := &net.IPNet{IP: net.IPv4(127, 0, 0, 2), Mask: net.CIDRMask(24, 32)}
+	addr := &Addr{IPNet: address}
 
 	link, err := LinkByName("lo")
 	if err != nil {

bridge_linux.go

@@ -3,8 +3,9 @@ package netlink
 import (
 	"fmt"
 
-	"github.com/vishvananda/netlink/nl"
 	"golang.org/x/sys/unix"
+
+	"github.com/vishvananda/netlink/nl"
 )
 
 // BridgeVlanList gets a map of device id to bridge vlan infos.
@@ -34,16 +35,14 @@ func (h *Handle) BridgeVlanList() (map[int32][]*nl.BridgeVlanInfo, error) {
 			return nil, err
 		}
 		for _, attr := range attrs {
-			switch attr.Attr.Type {
-			case unix.IFLA_AF_SPEC:
-				//nested attr
+			if attr.Attr.Type == unix.IFLA_AF_SPEC {
+				// nested attr
 				nestAttrs, err := nl.ParseRouteAttr(attr.Value)
 				if err != nil {
 					return nil, fmt.Errorf("failed to parse nested attr %v", err)
 				}
 				for _, nestAttr := range nestAttrs {
-					switch nestAttr.Attr.Type {
-					case nl.IFLA_BRIDGE_VLAN_INFO:
+					if nestAttr.Attr.Type == nl.IFLA_BRIDGE_VLAN_INFO {
 						vlanInfo := nl.DeserializeBridgeVlanInfo(nestAttr.Value)
 						ret[msg.Index] = append(ret[msg.Index], vlanInfo)
 					}

bridge_linux_test.go

@@ -33,10 +33,8 @@ func TestBridgeVlan(t *testing.T) {
 		} else {
 			if len(vInfo) != 1 {
 				t.Fatal()
-			} else {
-				if !vInfo[0].EngressUntag() || !vInfo[0].PortVID() || vInfo[0].Vid != 1 {
-					t.Fatalf("bridge vlan show get wrong return %s", vInfo[0].String())
-				}
+			} else if !vInfo[0].EngressUntag() || !vInfo[0].PortVID() || vInfo[0].Vid != 1 {
+				t.Fatalf("bridge vlan show get wrong return %s", vInfo[0].String())
 			}
 		}
 	}
@@ -61,17 +59,13 @@ func TestBridgeVlan(t *testing.T) {
 		}
 		if vInfo, ok := vlanMap[int32(bridge.Index)]; !ok {
 			t.Fatal("vlanMap should include foo port vlan info")
-		} else {
-			if fmt.Sprintf("%v", vInfo) != "[{Flags:6 Vid:1}]" {
-				t.Fatalf("unexpected result %v", vInfo)
-			}
+		} else if fmt.Sprintf("%v", vInfo) != "[{Flags:6 Vid:1}]" {
+			t.Fatalf("unexpected result %v", vInfo)
 		}
 		if vInfo, ok := vlanMap[int32(dummy.Index)]; !ok {
 			t.Fatal("vlanMap should include dum1 port vlan info")
-		} else {
-			if fmt.Sprintf("%v", vInfo) != "[{Flags:4 Vid:1} {Flags:0 Vid:2} {Flags:6 Vid:3}]" {
-				t.Fatalf("unexpected result %v", vInfo)
-			}
+		} else if fmt.Sprintf("%v", vInfo) != "[{Flags:4 Vid:1} {Flags:0 Vid:2} {Flags:6 Vid:3}]" {
+			t.Fatalf("unexpected result %v", vInfo)
 		}
 	}
 }

chain_linux.go

@@ -1,8 +1,9 @@
 package netlink
 
 import (
-	"github.com/vishvananda/netlink/nl"
 	"golang.org/x/sys/unix"
+
+	"github.com/vishvananda/netlink/nl"
 )
 
 // ChainDel will delete a chain from the system.
@@ -99,8 +100,7 @@ func (h *Handle) ChainList(link Link, parent uint32) ([]Chain, error) {
 
 		var chain Chain
 		for _, attr := range attrs {
-			switch attr.Attr.Type {
-			case nl.TCA_CHAIN:
+			if attr.Attr.Type == nl.TCA_CHAIN {
 				chain.Chain = native.Uint32(attr.Value)
 				chain.Parent = parent
 			}

class_linux.go

@@ -8,8 +8,9 @@ import (
 	"fmt"
 	"syscall"
 
-	"github.com/vishvananda/netlink/nl"
 	"golang.org/x/sys/unix"
+
+	"github.com/vishvananda/netlink/nl"
 )
 
 // Internal tc_stats representation in Go struct.

class_test.go

@@ -675,5 +675,4 @@ func TestClassHfsc(t *testing.T) {
 	if err := ClassChange(hfscClass); err != nil {
 		t.Fatal(err)
 	}
-
 }

cmd/ipset-test/main.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 package main
@@ -115,7 +116,7 @@ func cmdList(args []string) {
 	log.Printf("%+v", result)
 }
 
-func cmdListAll(args []string) {
+func cmdListAll(_ []string) {
 	result, err := netlink.IpsetListAll()
 	check(err)
 	for _, ipset := range result {