fix(webgl): Prevent auto resizing when using external gl context (9.0-release) #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
approved these changes
Dec 6, 2024
| @@ -203,7 +203,8 @@ ${device.info.vendor}, ${device.info.renderer} for canvas: ${device.canvasContex | |||
|
|
|||
| // Create and instrument context | |||
| const canvas = props.gl?.canvas || props.canvas; | |||
| this.canvasContext = new WebGLCanvasContext(this, {...props, canvas}); | |||
| const autoResize = !props.gl; | |||
There was a problem hiding this comment.
Is autoResize possibly overridden by the user in device props?
ibgreen
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2295
Change List
autoResizewhen using an external WebGL contextcssToDeviceRatio()fallback to canvas clientWidth when dimension cache is unavailable (this happens when resize() is never called)