Port fp64 module to UBO #2262
Merged
Port fp64 module to UBO #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Sep 20, 2024
| @@ -93,7 +93,7 @@ export {pbrMaterial} from './modules/lighting/pbr-material/pbr-material'; | |||
| // DEPRECATED - v8 legacy shader modules (non-uniform buffer) | |||
|
|
|||
| // math libraries | |||
| export {fp64, fp64arithmetic} from './modules-webgl1/math/fp64/fp64'; | |||
| // export {fp64, fp64arithmetic} from './modules-webgl1/math/fp64/fp64'; | |||
There was a problem hiding this comment.
Can we cut instead? At least on master which is targeting 9.2
There was a problem hiding this comment.
I'm in favour of removing all the old modules-webgl1 code & exports. I think it has all been ported
|
@ibgreen FYI when cherry-picking into 9.1 I removed:
from |
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For visgl/deck.gl#8997, once merged will also apply to
9.1-releaseto unblock visgl/deck.gl#9160Change List
defaultUniformsinstead ofgetUniforms