chore(shadertools): Support boolean shader defines only (v9.2) #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #
defines: Record<string, number, boolean>
=>defines: Record<string, boolean>
Background
#ifdef/#endif
processor in shadertools, but no interest in making it more full featured (e.g. support text replacement,#if defined(...)
etc.@override
constants for scalar values, that can be set at Pipeline creation "modifying" an already compiled shader. Suggest we add a newconstants
oroverrides
section for numeric values that takes advantage of this on WebGPU.Change List
defines
can only have boolean values.