fix(webgl): Apply default viewport sizes #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
requested review from
felixpalmer,
donmccurdy,
Pessimistress and
chrisgervang
chrisgervang
approved these changes
Jun 24, 2024
| `RenderPassProps.parameters.viewport` controls how the rendered graphics is mapped to window pixels / texels (more precisely, the affine transformation of x and y from normalized device coordinates to window coordinates). | ||
|
|
||
| If no value for the `viewport` parameter is provided, the following defaults will be applied. | ||
| - If no `framebuffer` is specified, the size of the canvas drawing buffer will be used (`[gl.canvas.drawingBufferWidth, gl.canvas.drawingBufferHeight]`) |
There was a problem hiding this comment.
Is there a WebGPU equivalent?
There was a problem hiding this comment.
Is there a WebGPU equivalent?
Very good point, the docs should not be WebGL specific. Will drop.
| supported = supported && checkTextureFeature(gl, info.f as DeviceFeature, extensions); | ||
| supported = supported && checkTextureFeature(gl, info.f, extensions); |
There was a problem hiding this comment.
Hard to tell in the diff, is this related?
There was a problem hiding this comment.
Huh, no, must be some some lint/prettier autofix. But if the casts are not needed, then better drop them...
|
LGTM assuming these values are post-application of device pixel ratio. |
donmccurdy
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Change List
Before
After
