Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dynamically load backends #2089

Merged
merged 4 commits into from
Sep 22, 2024
Merged

feat: Dynamically load backends #2089

merged 4 commits into from
Sep 22, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 29, 2024 •
edited
Loading

For #

Background

  • Implement dynamic import in webgl and webgpu modules

Change List

  • Breaking change luma.registerDevices() backwards compatibility was no longer feasible, apps must now update to luma.registerAdapters().

Follow up

  • webgpu and webgl index.ts should no longer export anything except the adapter and pure types?
  • How to measure bundle size impact?

@ibgreen ibgreen requested a review from Pessimistress April 29, 2024 19:47
@ibgreen ibgreen marked this pull request as ready for review April 30, 2024 01:11
@ibgreen ibgreen mentioned this pull request Apr 30, 2024
Merged
@ibgreen ibgreen force-pushed the ib/dynamic-backends branch from e2aefd8 to 4f4dd8a Compare April 30, 2024 12:06
@ibgreen ibgreen force-pushed the ib/dynamic-backends branch from 4f4dd8a to 6cb9ddf Compare September 22, 2024 13:54
@ibgreen ibgreen merged commit 728a13f into master Sep 22, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/dynamic-backends branch September 22, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen