Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bundle luma exports #3913

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Simplify bundle luma exports #3913

merged 1 commit into from
Nov 25, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Remove classes that are not needed by custom layers
  • Remove utility functions dropped in luma.gl v8
  • Remove shader modules that are re-exported by deck

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 80.868% when pulling 5d91b78 on x/bundle-deps into 5a92569 on master.

tsherif
tsherif approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@tsherif tsherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tsherif tsherif merged commit ba339f3 into master Nov 25, 2019
@tsherif tsherif deleted the x/bundle-deps branch November 25, 2019 22:25
@tsherif
Copy link
Contributor

tsherif commented Nov 25, 2019

@Pessimistress just gonna merge this so I can do the fixes for the new alpha without conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsherif tsherif tsherif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @tsherif