Caritas 286 create new endpoints #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create new endpoint to return all topics from all agencies of a tenant
* fix current tests
* add it tests for new getAgenciesTopics method
* add it and unit tests for new getAgenciesTopics method of the class AgencyService
* add unit tests for new class TopicEnrichmentService
* make sure the getAgenciesTopics method returns only the agency's topics for the current tenant
* create new endpoint to return an agency by postcode and topic id for the current tenant
* add new IT tests for the AgencyController
* add new IT tests for the AgencyService
* add new unit tests for the AgencyService
* add new authority for the new private endpoint, update its path and added the new authority to the SecurityConfig
* add new it tests and unit test to the AgencyController
tkuzynow
approved these changes
Oct 31, 2024
tkuzynow
reviewed
Nov 6, 2024
tkuzynow
reviewed
Nov 6, 2024
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/controller/AgencyController.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/repository/agency/AgencyRepository.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/service/AgencyService.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/service/AgencyService.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/service/AgencyService.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/service/TopicEnrichmentService.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/main/java/de/caritas/cob/agencyservice/api/service/TopicEnrichmentService.java
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/test/java/de/caritas/cob/agencyservice/api/controller/AgencyControllerTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/test/java/de/caritas/cob/agencyservice/api/controller/AgencyControllerTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/test/java/de/caritas/cob/agencyservice/api/controller/AgencyControllerTest.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/test/java/de/caritas/cob/agencyservice/testHelper/TestConstants.java
Outdated
Show resolved
Hide resolved
tkuzynow
reviewed
Nov 6, 2024
src/test/java/de/caritas/cob/agencyservice/api/controller/AgencyControllerIT.java
Outdated
Show resolved
Hide resolved
tkuzynow
requested changes
Nov 6, 2024
* fix all code following PR comments
tkuzynow
approved these changes
Nov 7, 2024
tkuzynow
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.