Allow virtual-kubelet to use cluster domain #8
Conversation
grahamhayes
changed the title
|
Marking as WIP, as virtual-kubelet/virtual-kubelet#642 needs to merge first, and then update the go.mod file to the commit with the new flag. |
grahamhayes
force-pushed
the
use-cluster-dns
branch
2 times, most recently
from
002ee23
to
9567a9a
Compare
grahamhayes
changed the title
grahamhayes
force-pushed
the
use-cluster-dns
branch
from
9567a9a
to
667a80d
Compare
grahamhayes
force-pushed
the
use-cluster-dns
branch
from
a427357
to
16ba32f
Compare
grahamhayes
force-pushed
the
use-cluster-dns
branch
from
16ba32f
to
90ddefb
Compare
grahamhayes
force-pushed
the
use-cluster-dns
branch
2 times, most recently
from
10ed07d
to
7c7f076
Compare
aci.go
Outdated
|
|
||
| containerGroup.ContainerGroupProperties.Extensions = []*aci.Extension{p.kubeProxyExtension} | ||
| containerGroup.ContainerGroupProperties.DNSConfig = p.getDNSConfig(pod.Spec.DNSPolicy, pod.Spec.DNSConfig) | ||
| containerGroup.ContainerGroupProperties.DNSConfig = p.getDNSConfig(pod) |
|
Sorry this needs a rebase now that we've updated to vk 1.0 |
|
@cpuguy83 / @ibabou should I keep rebasing this? this new rebase looks like it will take a bit more time (#13 changed the flow for some files / calls) , and I will need to retest - it is a non trivial time investment. It seems like something a customer using vk will run into (it was one of the first things we ran into), but has been open for an extended period. |
|
@grahamhayes Looks like it's good to go as soon as there's a rebase. Originally just been waiting for someone from ACI to review which is now ok :) |
|
As described in #46 and since everything seems to be ready to merge, when can we close and have a new release with this? Thank you |
|
@grahamhayes @cpuguy83 when can we merge this and have a new release? it would be much appreciated. thank you |
|
sorry to keep insisting but I've been having random timeouts due to dns issues with virtual-kubelet (while explicitly setting Any timeline on this? Thank you. |
This allows `--cluster-domain` to be passed to virtual kubelet like a traditional kublet, and use this to generate search-domains for `/etc/resolv.conf` * Only apply to pods with `DNSClusterFirst` to match kubelet * Merge search-domains with any set in the `dnsConfig` * Set `ndots` to the default 5 Related: virtual-kubelet#641 Depends-On: virtual-kubelet/virtual-kubelet#642 Signed-off-by: Graham Hayes <[email protected]>
cpuguy83
force-pushed
the
use-cluster-dns
branch
from
7c7f076
to
ce51524
Compare
This allows
--cluster-domainto be passed to virtual kubelet like atraditional kublet, and use this to generate search-domains for
/etc/resolv.confDNSClusterFirstto match kubeletdnsConfigndotsto the default 5Related: #641
Depends-On: virtual-kubelet/virtual-kubelet#642
Signed-off-by: Graham Hayes [email protected]