Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for providing Log Analytics Id and Key, and Custom columns in the pod spec #352

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pvashisht888
Copy link

  1. Added a CA cert env var so that we can see logs through kubectl for a pod running in ACI.
  2. Added a new extension for CustomLogger so that logs can be seen in a Log Analytics workspace for a CG running in ACI through the virtual kubelet. The LA Id and Key is provided through the annotations in the pod spec.
  3. Added support for showing custom columns in Log Analytics workspace for a CG running in ACI through the virtual kubelet. These custom columns (and their values) are also provided in the pod spec as an annotation which are then parsed and supplied to the custom logger extension. These columns (and their values) are visible in ContainerAppConsoleLogs_CL table in the Log Analytics workspace.

@pvashisht888 pvashisht888 temporarily deployed to test November 2, 2022 21:03 Inactive
@pvashisht888 pvashisht888 temporarily deployed to test November 2, 2022 21:03 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #352 (f79b88c) into master (55027d0) will increase coverage by 0.75%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   44.65%   45.41%   +0.75%     
==========================================
  Files          46       46              
  Lines        5860     5919      +59     
==========================================
+ Hits         2617     2688      +71     
+ Misses       2992     2979      -13     
- Partials      251      252       +1     
Impacted Files Coverage Δ
provider/aci.go 40.63% <85.00%> (+2.85%) ⬆️
provider/aciMock.go 65.51% <0.00%> (+1.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants