Added new snpguest CI PR test for SNP guest #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larrydewey
approved these changes
Oct 28, 2024
AdithyaKrishnan
approved these changes
Nov 15, 2024
…ithout network port conflict Added a new tool to assign network ports to multiple SNP guest without network port conflict and cleanup inactive guest network port inthe inventory file tracked by GH Action workflow Signed-off-by: Harika Nittala <[email protected]>
…ted runner. Added a new helper script having function definition for SNP related tasks(verify if SNP is enabled for the SNP host kernel, run a command on an active guest) and host dependencies(check rust dependency) on the self-hosted runner. Signed-off-by: Harika Nittala <[email protected]>
Added snpguest CI PR test workflow to run snpguest cargo tests(without flags) on the SNP guest Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
force-pushed
the
snpguest-ci-pr-test
branch
from
c45ff4e to
d39ee5a
Compare
|
Hi Reviewers, I re-request for the code review for snpguest CI PR test as I made major changes to address the following features:
|
|
|
||
| #!/bin/bash | ||
|
|
||
| verify_snp_host() { |
There was a problem hiding this comment.
Can I add this as a separate command in snp.sh or
use this as it is in the workflow
| } | ||
|
|
||
| # verify_snp_guest_msr CLI use: verify_snp_guest_msr "${guest_name}" "${guest_port_number}" | ||
| verify_snp_guest_msr(){ |
There was a problem hiding this comment.
Can remove this function if we can integrate this functionality in the snp.sh
| run: | | ||
| set -e | ||
|
|
||
| wget https://raw.githubusercontent.com/LakshmiSaiHarika/sev-utils/Fedora-Latest-SNP-kernel-Upstream/tools/snp.sh |
There was a problem hiding this comment.
| export GUEST_NAME=${{ env.guest_name }} | ||
| export HOST_SSH_PORT=${{ env.guest_port_in_use }} | ||
|
|
||
| ./snp.sh launch-guest |
There was a problem hiding this comment.
./snp.sh launch-guest --guest-name "${{ env.guest_name }}" --guest-port "${{ env.guest_port_in_use }}"
| source ./.github/workflows/snp_function_declarations.sh | ||
| ssh_guest_command "uname -r" ${{ env.guest_name }} ${{ env.guest_port_in_use }} | ||
|
|
||
| - name: Verify SNP on the guest via MSR |
There was a problem hiding this comment.
Can remove this once this functionality is added in the snp.sh
|
|
||
| export GUEST_NAME=${{ env.guest_name }} | ||
| export HOST_SSH_PORT=${{ env.guest_port_in_use }} | ||
| ./snp.sh stop-guests |
There was a problem hiding this comment.
./snp.sh stop-guests --guest-name "${{ env.guest_name }}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform snpguest cargo tests on the SNP guest