-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider new test menu implementation #62
Open
kosist
wants to merge
23
commits into
vipm-io:Provider-New-Test-Menu
Choose a base branch
from
kosist:Provider-New-Test-Menu
base: Provider-New-Test-Menu
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Provider new test menu implementation #62
kosist
wants to merge
23
commits into
vipm-io:Provider-New-Test-Menu
from
kosist:Provider-New-Test-Menu
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider is needed, b/c existing provider is not for classes
… Renamed menu item to "VI Tester Test Method". Added check whether right-clicked class is TestCase child (recursively)
…source and compiled code
method is added but needs to be saved again after added to library
…n scripter. Issue with class referense persists
…ould wait till the end of the VI's execution
Hello @jimkring , let me please just ask, whether you'll have time in some near future to review this pull request? Thank you very much, Sincerely, Ivan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jimkring,
finally I've managed to finalize implementation of feature #59 to some point.
I have added additional project provider, because it was not possible to add this functionality to existing one (due to GUID in .ini file).
There is new folder "Add Test Method Provider" in the source code.
Overall idea is the following.
User right-clicks on the class -> provider checks, whether class has TestCase.lvclass in its hierarchy. If so, then New -> VI Tester Test Method menu entry is added.
When this menu item is selected, there is opened window to create new test method.
By default, "standard" template is used (which is installed with the toolkit).
But user could place his own templates to proper directory, so then he could select that particular template for the test method. For example, someone likes "Given, When, Then" template from VITAC toolkit -> so such template could be stored to "resource\JKI\VI Tester\Templates\Method Templates\Custom" directory, and then it is possible to select it and generate new test method based on that template.
Now there is simple validation of the template - it must have "TestCase in" and "TestCase out" input/output of the class datatype.
When custom templates are found, they are displayed in the drop-down list. If they are not found, drop-down list is hidden.
In order to select custom template from the drop-down list, checkbox "Use Template?" must be selected. Then drop-down list will be enabled, and user could select particular template.
As I understand, package is built using OpenG builder, so I didn't know how to build it... I was copying VIs manually, relinked template methods in order to use TemplateTestClass.lvclass from LabVIEW folder, and tested like that.
Let me, please, describe installation paths for the new files, located in "Add Test Method Provider" folder.
Let me, please, ask you to help with package build, so it will be possible to test the implementation in complete setup?
Thank you very much in advance,
hope that implementation is fine...
Sincerely, Ivan.