Disable code emitting heap-dependent triggers if verified member does not use them #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoeilers
changed the title
…nt member; state consolidation uses alternative quantifier that does not require field trigger
marcoeilers
changed the title
jcp19
approved these changes
Oct 31, 2022
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code that checks for which fields, predicates and wands the currently verified member uses resource triggers. For all resources not used as triggers, it disables all code in Silicon that emits those triggers and, in particular, prevents Silicon from emitting snapshot maps etc. that are required only for those triggers.
Its purpose is to improve performance for Viper code that does not use such triggers, in particular, Gobra-generated code used in the VerifiedSCION project, which reportedly gets a big performance improvement from disabling them.
The state consolidator uses field triggers when emitting a quantifier stating that for all fields, the permission amount is at most one; for fields not used in field triggers, this code is changed to use different triggers instead (since the field triggers wouldn't work).