Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-side-effectful conversions in spec #600

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Jan 22, 2023

Currently, type conversions cannot have ghost child nodes. This is unnecessarily restrictive. This PR lifts such a restriction and allows non-effectful conversions to be used in spec.

Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise ok.

@jcp19 jcp19 merged commit 539f2a3 into master Jan 23, 2023
@jcp19 jcp19 deleted the joao-allow-conversions-spec branch January 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants