Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print early errors that don't go through the streaming reporter #597

Merged
merged 11 commits into from
Jan 19, 2023

Conversation

Dspil
Copy link
Contributor

@Dspil Dspil commented Jan 13, 2023

Errors that do not get produced by the backend (typechecking and parsing errors) didn't pass through the streaming reporter so they were not reported. Now the verificationFailure instead of a vector of errors takes an Either as a parameter to distinguish between errors produced by the backend or not so they are printed if the streaming reporter hasn't printed them already. A simple example is the following:

package test

import "context"

func f() 

If context is not in the directories passed as arguments to Gobra, Gobra produces an error saying that this qualifier could not be derived. This kind of error did not pass through the reporter so it was not printed.

@Dspil Dspil requested review from ArquintL and jcp19 January 13, 2023 11:11
@Dspil Dspil requested review from Felalolf and jcp19 and removed request for ArquintL January 19, 2023 14:22
Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, looks ok, but let joao also have a look

@Dspil Dspil merged commit e41aed3 into master Jan 19, 2023
@Dspil Dspil deleted the dspil_print_early_errors branch January 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants