Range #551
Merged
Range #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcp19
requested changes
Oct 16, 2022
jcp19
reviewed
Oct 17, 2022
I think it is because I added execute permissions to it to run it and git captured that too. |
Felalolf
reviewed
Oct 17, 2022
jcp19
reviewed
Oct 18, 2022
src/main/scala/viper/gobra/frontend/info/base/SymbolTable.scala
Outdated
Show resolved
Hide resolved
Comment on lines
295
to
299
| underlyingType(exprType(exp)) match { | ||
| case _: SliceT | _: ArrayT => IntT(config.typeBounds.Int) | ||
| case MapT(key, _) => SetT(key) | ||
| case t => violation(s"type $t is not supported for range") | ||
| } |
There was a problem hiding this comment.
This seems like a repeated pattern, maybe we could abstract this in a method
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range for slices/arrays is reworked as discussed.
Range for maps is also implemented.
Variables declared with := in range expressions can be shared now (this is the case with Go)