Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Pure Function Calls whose Result is Unused #550

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Fixes Pure Function Calls whose Result is Unused #550

merged 2 commits into from
Oct 17, 2022

Conversation

ArquintL
Copy link
Member

@ArquintL ArquintL commented Oct 13, 2022 •
edited
Loading

@jcp19 I'm not feeling super confident with the writer pattern, so please take a look.

@ArquintL
assigns expression in expression statement to a fresh variable to ens…
d3a7682 
…ure that the expression does not get lost in the internal representation
@ArquintL ArquintL requested a review from jcp19 October 13, 2022 09:53
@ArquintL
Copy link
Member Author

@jcp19 and I have discussed different solutions yesterday and the one currently implemented is the best one we came up with. @Felalolf Do you have ideas for alternative solutions?

jcp19
jcp19 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would wait for @Felalolf's opinion before merging

Felalolf
Felalolf approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have solved it the same way (probably without the optimization).

@ArquintL ArquintL merged commit da7e575 into master Oct 17, 2022
@ArquintL ArquintL deleted the do-not-drop-pure-fn-calls branch October 17, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felalolf Felalolf Felalolf approved these changes

@jcp19 jcp19 jcp19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArquintL @jcp19 @Felalolf