-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gobra to the newest Viper version #499
Conversation
@jcp19 ViperServer (i.e. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it is the best idea to make Viper Server determine which Silicon, Carbon, and Silver version Gobra uses. That said, I guess we can still pick individual Silicon, Carbon, Silver versions by creating a ViperServer branch with the set of depencies that we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the following entries from .gitignore
:
carbon
silver
silicon
viperserver
I think it's good that ViperServer determines the dependent commits since this is tested & guaranteed to work. We'll typically either use a Viper release (with fixed commits for ViperServer, Carbon, Silicon, and Silver) or a nightly release of ViperServer. In the latter case, the current |
This PR updates Gobra to use the latest changes as of today (01.09.2022). Initially, it was meant to update Gobra to use the viper version from the
22.07
release, but instead it uses a more recent version than that due to nice-to-have changes made recently (in particular, viperproject/silver#604).Furthermore, in this PR, I removed
ViperChopper
- instead, we now useChopper
provided by silver. Furthermore, I changed Gobra to use submodules, which makes the process of upgrading and installing Gobra a lot easier! Thanks @ArquintL for changing viperserver to use modules.