Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate type tags in the encoding #472

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Jun 23, 2022

As it stands, Gobra generates repeated occurrences of the following four functions, corresponding to the type tags of int32 and rune (its synonym), and int8 and bytes (also synonyms) (for some reason, this problem was never triggered in the CI before). This PR addresses that.

  function int32_Types(): Types
  unique function int32_Types_tag(): Int
  function byte_Types(): Types
  unique function byte_Types_tag(): Int

@jcp19 jcp19 requested a review from Felalolf June 23, 2022 15:23
@jcp19 jcp19 requested review from ArquintL and Dspil June 23, 2022 16:35
@jcp19 jcp19 merged commit 4ac9627 into master Jun 24, 2022
@jcp19 jcp19 deleted the fix-duplicate-type-tags branch June 24, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants