Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make defer statement ghostifiable #470

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Make defer statement ghostifiable #470

merged 2 commits into from
Jun 23, 2022

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Jun 22, 2022

Just noticed that defer cannot be used in ghost contexts, which is useful when deferring a fold/unfold.

@jcp19 jcp19 requested a review from Felalolf June 22, 2022 15:20
Felalolf
Felalolf approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also check that you cannot ghostify an actual call, but you can also do that in a later PR.

@jcp19 jcp19 merged commit 8f18f63 into master Jun 23, 2022
@jcp19 jcp19 deleted the defer-ghostifiable branch June 23, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felalolf Felalolf Felalolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcp19 @Felalolf