Implement tagged hashes for the leafhashes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcalvinalvin
force-pushed
the
2024-01-10-super-basic-tagged-hash-impl
branch
from
ec37474
to
d25be5c
Compare
For versioning purposes, we want to prepend the preimage with a tag. There's more efficient ways to do this but that requires modifying rust-bitcoin and this is just the most straightforward way to implement tagged hashes.
kcalvinalvin
force-pushed
the
2024-01-10-super-basic-tagged-hash-impl
branch
from
d25be5c
to
3462e50
Compare
|
Fixed all the bugs and verified that the generated roots are the same as utreexod by using the same Relevant PR here: |
|
Concept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For versioning purposes, we want to prepend the preimage with a tag. There's more efficient ways to do this but that requires modifying rust-bitcoin and this is just the most straightforward way to implement tagged hashes.