deprecate EMAIL_CONFIRM_LA_HTTP_PROTOCOL and EMAIL_CONFIRM_LA_DOMAIN

[vinta]

We should use EMAIL_CONFIRM_LA_TEMPLATE_CONTEXT instead.

EMAIL_CONFIRM_LA_TEMPLATE_CONTEXT = {
    'SITE_URL': 'http://example.com',
}

[PedroPCardoso]

EMAIL_CONFIRM_LA_DOMAIN can be omitted and Site.objects.get_current().domain will be used ?

Omitted :

EMAIL_CONFIRM_LA_HTTP_PROTOCOL = 'http'
EMAIL_CONFIRM_LA_CONFIRM_EXPIRE_SEC = 60 * 60 * 24 * 7 # 7 days
EMAIL_CONFIRM_LA_CONFIRM_URL_REVERSE_NAME = 'email_confirm_la:confirm_email'
EMAIL_CONFIRM_LA_TEMPLATE_CONTEXT = {}
EMAIL_CONFIRM_LA_AUTOLOGIN = True

and send email: http://example.com/email_confirmation/key/57c3bf1f5d174e8cb7ad8a7f52caf537/

no have using my bd django sites,But it uses the default value.

[vinta]

I'm planning to do:

Remove those two settings:

• EMAIL_CONFIRM_LA_HTTP_PROTOCOL
• EMAIL_CONFIRM_LA_DOMAIN

Explicitly specify SITE_URL in EMAIL_CONFIRM_LA_TEMPLATE_CONTEXT.

Make EmailConfirmation.send() use SITE_URL to construct the full URL inside the confirmation mail. Maybe fall back to Site.objects.get_current().domain.

[cmdelatorre]

Although the README says

If you are using the sites framework, then EMAIL_CONFIRM_LA_DOMAIN can be omitted and Site.objects.get_current().domain will be used.

That is actually not happening. This caused us great trouble.

Any plans to fix that?

[PedroPCardoso]

If you add in the code and in the documentation, a migrate for the user to set your domain. Because the problem is that when using the default it uses the default of django itself which is www.example.com 2017-03-27 12:55 GMT+00:00 Carlos de la Torre <[email protected]>:

…

Although the README says If you are using the sites framework, then EMAIL_CONFIRM_LA_DOMAIN can be omitted and Site.objects.get_current().domain will be used. That is actually not happening. This caused us great trouble. Any plans to fix that? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHTZm1GQtJz8Yf7fC7MRfOpbd9vfNcozks5rp7GmgaJpZM4JU9-3> .

-- João Pedro Cardoso *http://lattes.cnpq.br/3682402342405212 <http://lattes.cnpq.br/3682402342405212>* *"*As pessoas não sabem o que querem, até mostrarmos a ela.*"**Steve Jobs*

[cmdelatorre]

What you propose does not work. We are using version 2.3.0
We do have the site's domain set but still the default example.com is used (unless we change it in the settings). What's more, apparently Site.objects.get_current().domain is NOT being used at all in the code.