Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding contacts.html #164

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeenashetti
Copy link

@jeenashetti jeenashetti commented Mar 18, 2021

Description

Added contacts.html file which includes contributors/admin information and GitHub repo

Fixes #160

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link

welcome bot commented Mar 18, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

Copy link
Collaborator

@Kashish121 Kashish121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeenashetti Unfortunately, there's a little blunder here. You forked master branch to make changes, and then you created a PR in develop branch.

This can't work because master uses python2.X and develop uses python3.X.

What should you do:

  1. switch to develop branch.
  2. Make the corresponding changes.
  3. Create PR in develop.

😄

Copy link
Collaborator

@Kashish121 Kashish121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by mistake, changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants