Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to python3.8+ #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Migration to python3.8+ #143

wants to merge 3 commits into from

Conversation

ranaaditya
Copy link

Description

This PR is for the Migration of the project from python 2.7 to python 3.8+

Fixes # (issue)

Type of change

  • Migrate the version of python so that new contributors can contribute hassle freely.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link

welcome bot commented Mar 12, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

@ranaaditya
Copy link
Author

ranaaditya commented Mar 12, 2021 •
edited
Loading

Hi @vinitshahdeo please change the labels for this PR !

@vinitshahdeo vinitshahdeo added gssoc21 Level2 Minor Feature or Bug Fix labels Mar 13, 2021
Kashish121
Kashish121 requested changes Mar 14, 2021
View reviewed changes
src/mainScanner.py
@@ -19,7 +19,7 @@ def homepage():
return render_template('index.html')


exc = getattr(__builtin__, "IOError", "FileNotFoundError")
exc = getattr(__builtins__, "IOError", "FileNotFoundError")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this line would not throw error while running.
It should be
exc = getattr(builtins, "IOError", "FileNotFoundError")
instead of
exc = getattr(__builtins__, "IOError", "FileNotFoundError"),
I suppose.

Reference.

@ranaaditya does this file execute normally with __builtins__ ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was working fine in my local.

Kashish121
Kashish121 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@Kashish121 Kashish121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to go then.

@ranaaditya
Copy link
Author

ranaaditya commented Mar 22, 2021 •
edited
Loading

@vinitshahdeo can you please review this PR and merge if possible ?

@ranaaditya
Copy link
Author

@vinitshahdeo can you please review this PR and merge if possible ?

@Kashish121 whats the status about this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kashish121 Kashish121 Kashish121 approved these changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees
No one assigned
Labels
gssoc21 Level2 Minor Feature or Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranaaditya @Kashish121 @vinitshahdeo