Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little code optimization. #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

coderj001
Copy link

@coderj001 coderj001 commented Oct 20, 2020

Description

Type of change

Converted hardcoded path '../config.json' to os path. As their no longer need to worry if that directory path had a trailing slash or not. os.path.join will add it if it needs to.

Checklist:

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link

welcome bot commented Oct 20, 2020

Thanks for opening this pull request! 🤗
Wishing you a great Hacktoberfest 2020 🙌 🎉 ⚡️
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

📢 Spread the word about @vinitshahdeo/Hacktoberfest2020 repo across your social media channels to help get others involved! Give a shoutout to DEV article. Retweet this.

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

@coderj001
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant