Skip to content

Commit

Permalink
mm-swap-add-swap_cluster_list-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: Missing a blank line after declarations
torvalds#91: FILE: mm/swapfile.c:285:
+		unsigned int tail = cluster_next(&list->tail);
+		cluster_set_next(&ci[tail], idx);

WARNING: line over 80 characters
torvalds#261: FILE: mm/swapfile.c:2347:
+			cluster_list_add_tail(&p->free_clusters, cluster_info, idx);

total: 0 errors, 2 warnings, 222 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-swap-add-swap_cluster_list.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Huang Ying <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and sfrothwell committed Oct 1, 2016
1 parent b8265da commit b31f656
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion mm/swapfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ static void cluster_list_add_tail(struct swap_cluster_list *list,
cluster_set_next_flag(&list->tail, idx, 0);
} else {
unsigned int tail = cluster_next(&list->tail);

cluster_set_next(&ci[tail], idx);
cluster_set_next_flag(&list->tail, idx, 0);
}
Expand Down Expand Up @@ -2344,7 +2345,8 @@ static int setup_swap_map_and_extents(struct swap_info_struct *p,
for (i = 0; i < nr_clusters; i++) {
if (!cluster_count(&cluster_info[idx])) {
cluster_set_flag(&cluster_info[idx], CLUSTER_FLAG_FREE);
cluster_list_add_tail(&p->free_clusters, cluster_info, idx);
cluster_list_add_tail(&p->free_clusters, cluster_info,
idx);
}
idx++;
if (idx == nr_clusters)
Expand Down

0 comments on commit b31f656

Please sign in to comment.