forked from apache/hbase
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty h…
…andler (apache#4624) Signed-off-by: Xin Sun <[email protected]>
- Loading branch information
Showing
19 changed files
with
507 additions
and
466 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 0 additions & 47 deletions
47
hbase-client/src/main/java/org/apache/hadoop/hbase/security/CryptoAESUnwrapHandler.java
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
hbase-client/src/main/java/org/apache/hadoop/hbase/security/CryptoAESWrapHandler.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyHBaseSaslRpcServerHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.ipc; | ||
|
|
||
| import java.io.IOException; | ||
| import org.apache.hadoop.hbase.security.HBaseSaslRpcServer; | ||
| import org.apache.hadoop.hbase.security.SaslStatus; | ||
| import org.apache.hadoop.hbase.security.SaslUnwrapHandler; | ||
| import org.apache.hadoop.hbase.security.SaslWrapHandler; | ||
| import org.apache.hadoop.hbase.util.NettyFutureUtils; | ||
| import org.apache.hadoop.io.BytesWritable; | ||
| import org.apache.hadoop.io.Writable; | ||
| import org.apache.hadoop.io.WritableUtils; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import org.apache.hbase.thirdparty.io.netty.buffer.ByteBuf; | ||
| import org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.ChannelHandlerContext; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.ChannelPipeline; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.SimpleChannelInboundHandler; | ||
| import org.apache.hbase.thirdparty.io.netty.handler.codec.LengthFieldBasedFrameDecoder; | ||
|
|
||
| /** | ||
| * Implement SASL negotiation logic for rpc server. | ||
| */ | ||
| class NettyHBaseSaslRpcServerHandler extends SimpleChannelInboundHandler<ByteBuf> { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(NettyHBaseSaslRpcServerHandler.class); | ||
|
|
||
| static final String DECODER_NAME = "SaslNegotiationDecoder"; | ||
|
|
||
| private final NettyRpcServer rpcServer; | ||
|
|
||
| private final NettyServerRpcConnection conn; | ||
|
|
||
| NettyHBaseSaslRpcServerHandler(NettyRpcServer rpcServer, NettyServerRpcConnection conn) { | ||
| this.rpcServer = rpcServer; | ||
| this.conn = conn; | ||
| } | ||
|
|
||
| private void doResponse(ChannelHandlerContext ctx, SaslStatus status, Writable rv, | ||
| String errorClass, String error) throws IOException { | ||
| // In my testing, have noticed that sasl messages are usually | ||
| // in the ballpark of 100-200. That's why the initial capacity is 256. | ||
| ByteBuf resp = ctx.alloc().buffer(256); | ||
| try (ByteBufOutputStream out = new ByteBufOutputStream(resp)) { | ||
| out.writeInt(status.state); // write status | ||
| if (status == SaslStatus.SUCCESS) { | ||
| rv.write(out); | ||
| } else { | ||
| WritableUtils.writeString(out, errorClass); | ||
| WritableUtils.writeString(out, error); | ||
| } | ||
| } | ||
| NettyFutureUtils.safeWriteAndFlush(ctx, resp); | ||
| } | ||
|
|
||
| @Override | ||
| protected void channelRead0(ChannelHandlerContext ctx, ByteBuf msg) throws Exception { | ||
| LOG.debug("Read input token of size={} for processing by saslServer.evaluateResponse()", | ||
| msg.readableBytes()); | ||
| HBaseSaslRpcServer saslServer = conn.getOrCreateSaslServer(); | ||
| byte[] saslToken = new byte[msg.readableBytes()]; | ||
| msg.readBytes(saslToken, 0, saslToken.length); | ||
| byte[] replyToken = saslServer.evaluateResponse(saslToken); | ||
| if (replyToken != null) { | ||
| LOG.debug("Will send token of size {} from saslServer.", replyToken.length); | ||
| doResponse(ctx, SaslStatus.SUCCESS, new BytesWritable(replyToken), null, null); | ||
| } | ||
| if (saslServer.isComplete()) { | ||
| conn.finishSaslNegotiation(); | ||
| String qop = saslServer.getNegotiatedQop(); | ||
| boolean useWrap = qop != null && !"auth".equalsIgnoreCase(qop); | ||
| ChannelPipeline p = ctx.pipeline(); | ||
| if (useWrap) { | ||
| p.addFirst(new SaslWrapHandler(saslServer::wrap)); | ||
| p.addLast(new LengthFieldBasedFrameDecoder(Integer.MAX_VALUE, 0, 4, 0, 4), | ||
| new SaslUnwrapHandler(saslServer::unwrap)); | ||
| } | ||
| conn.setupDecoder(); | ||
| p.remove(this); | ||
| p.remove(DECODER_NAME); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { | ||
| LOG.error("Error when doing SASL handshade, provider={}", conn.provider, cause); | ||
| Throwable sendToClient = HBaseSaslRpcServer.unwrap(cause); | ||
| doResponse(ctx, SaslStatus.ERROR, null, sendToClient.getClass().getName(), | ||
| sendToClient.getLocalizedMessage()); | ||
| rpcServer.metrics.authenticationFailure(); | ||
| String clientIP = this.toString(); | ||
| // attempting user could be null | ||
| RpcServer.AUDITLOG.warn("{}{}: {}", RpcServer.AUTH_FAILED_FOR, clientIP, | ||
| conn.saslServer != null ? conn.saslServer.getAttemptingUser() : "Unknown"); | ||
| NettyFutureUtils.safeClose(ctx); | ||
| } | ||
| } |
Oops, something went wrong.