-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken in neovim nightly #46
Comments
Looks like your config works with neovim 0.8.3 but not with nightly. Bisecting neovim confirms that either 24488169564c39a506c235bf6a33b8e23a8cb528 or 43e8ec92de9e0850e7d202cb7ff9051bc408447e introduced a regression, where neovim causes the asynchronous background job to segfault. Both of these commits come from neovim/neovim#18375 and looking at the references at the end of that thread, that PR introduced a lot of other regressions, sigh... Some of the regressions are very similar to this bug: neovim/neovim#21771 I will have to see how to fix this properly, but it probably requires upstream work. |
Curious about this. what more state do you rely on being synchronized, apart from cwd as in the linked issue? |
This comment was marked as outdated.
This comment was marked as outdated.
@bfredl It seems that your patch regressed detection of whether neovim runs in a GUI or in the TUI. From the help page
However, after your patch this is no longer true. You can test it out with: nvim --clean -Nu <(cat<<EOF
au UIEnter * echom v:event['chan']
EOF) Before your patch this correctly displayed 0 (as per documentation). After your patch it returns 1 instead. What is the recommended way to detect TUI neovim (as opposed to neovim started in a GUI) now? Please make sure to update the neovim help page (or fix it to return 0 again). The |
For the moment, I think the simplest way might be |
For reference: |
It looks like finally neovim got sane GUI detection support, like vim [0]. This means we can remove the temporary workaround from 95a6ccb completely. Nightly neovim users who used a version of neovim released after the broken 2022-12-01 version [1], but before the fix in 2023-02-28, should update their version of neovim as soon as possible, as the root of the problem is now properly fixed for neovim 0.9. Fixes #46. [0] neovim/neovim#22382 [1] neovim/neovim#18375
Describe the bug
Title says it all - I can't seem to get this to work at all. I'm running nightly neovim and haven't had any luck. By any chance would you mind taking a peek at my config and helping me diagnose what might be the problem? I'm curious if it has something to do with using lazy as my package manager, but it's hard to debug when I can't get anything to even happen.
To reproduce
If you clone
[email protected]:jrnxf/dot.git
and check out thetpipeline
branch, you should be able to replicateOf course you'll want to use my tmux and neovim configs. If you open up neovim with my config it should load everything on start. It might throw some errors but just exit out once and open it back up and you should be good to go.
Expected behavior
No response
Terminal emulator
iterm2
Debug output
No response
The text was updated successfully, but these errors were encountered: