Add BitwiseNot and BooleanNot operators to SimpleTypeInferer #8360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwise-operators
force-pushed
the
8307-operand-class-constants
branch
from
e602d1b to
f782313
Compare
AndrolGenhald
added
the
release:fix
|
Wow, I can't believe how your username is fitting with this PR! I even went to check on your profile whether every previous issue you opened here was also related to bitwise operators or not 😄 |
orklah
reviewed
Aug 3, 2022
src/Psalm/Internal/Analyzer/Statements/Expression/SimpleTypeInferer.php
Outdated
Show resolved
Hide resolved
|
Could you add a couple of tests for these cases (probably in ConstantTest.php)? LGTM after that's done. |
…ean-not class constants
Done. I also added tests for two other missing bitwise operators. |
AndrolGenhald
approved these changes
Aug 4, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitwiseNotandBooleanNotoperators were missing from theSimpleTypeInferer. This PR adds them.This should fix #8307.
Thanks to @AndrolGenhald for pointing me in the right direction.