Use InvalidScalarArgument only when we can be sure PHP attempts coercion #7188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muglug
added
the
release:fix
muglug
force-pushed
the
muglug-use-invalidscalarargument-less
branch
from
78450c2 to
87a7a88
Compare
|
This would make sense. It would be great to document this somewhere. Maybe a comment on the scalar_type_match_found property and an explanation in the Issue page? |
|
@weirdan should we merge this now or is it something we will add to Psalm 5? |
That would be my preference, yes. |
weirdan
force-pushed
the
muglug-use-invalidscalarargument-less
branch
from
06dd642 to
1e115da
Compare
This was referenced Feb 20, 2023
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #7181
It narrows the occasions where
InvalidScalarArgumentis emitted to only the places where we're sure that PHP will attempt to coerce one scalar type to another. This matches the original intent ofInvalidScalarArgument— a lesser issue thanInvalidArgument, for when the PHP runtime may not care.