Support PHP_VERSION_ID in conditional types #6783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
reviewed
Oct 29, 2021
|
Thanks! |
weirdan
added
the
release:feature
weirdan
changed the title
sad-spirit
added a commit
to sad-spirit/pg-wrapper
that referenced
this pull request
Nov 18, 2021
This fixes most of the PossiblyInvalidArgument issues in psalm, we suppress the remaining ones and similar phpstan issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @weirdan in #6755 considering return type changes in PHP 8.1
I wouldn't claim that I completely understand all the changes I made, but I used 42802e1 as a reference.