Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update psl version used in e2e tests #6766

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Oct 28, 2021

closes #6706

@azjezz azjezz force-pushed the chore/update-psl branch 3 times, most recently from 38cf6a6 to cba56b6 Compare October 28, 2021 05:04
@azjezz
Copy link
Contributor Author

azjezz commented Oct 28, 2021

@orklah can i have write access to psalm/endtoend-test-psl repository? the baseline needs to be updated, i will also update PSL project structure in next few days in order to make it simpler to test here.

@orklah
Copy link
Collaborator

orklah commented Oct 28, 2021

Thanks for that, I was a little lost.

I don't have write permissions on it either. I'm gonna ask Matt.

@azjezz
Copy link
Contributor Author

azjezz commented Oct 28, 2021

The issue was that phpbench isn't installed, but a file from it's source is referenced as extraFile in the configuration, i guess the error message could be improved, something like "configuration: unable to locate extra file 'path/to/file'", currently this is the error you get:

Problem parsing /home/azjezz/Projects/psalm/testing-with-real-projects/endtoend-test-psl/tools/psalm/psalm.xml:
  Could not resolve config path to /home/azjezz/Projects/psalm/testing-with-real-projects/endtoend-test-psl/tools/psalm//

@muglug
Copy link
Collaborator

muglug commented Oct 28, 2021

@azjezz just invited you to that repo

@muglug
Copy link
Collaborator

muglug commented Nov 4, 2021

Sorry @azjezz just realised I invited you to muglug/psl not psalm/endtoend-test-psl

@orklah orklah mentioned this pull request Nov 5, 2021
@azjezz azjezz force-pushed the chore/update-psl branch 2 times, most recently from a5ad90c to 2416266 Compare November 6, 2021 05:48
@azjezz
Copy link
Contributor Author

azjezz commented Nov 6, 2021

Thanks @muglug

@orklah build is passing, except for missing label.

@orklah
Copy link
Collaborator

orklah commented Nov 6, 2021

@azjezz cool! Can you rebase and add 73b5c9f back again?

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 6, 2021
@azjezz
Copy link
Contributor Author

azjezz commented Nov 6, 2021

rebased!

@azjezz
Copy link
Contributor Author

azjezz commented Nov 6, 2021

PSL 2.0 has standard project structure, but i think we should wait before switching to 2.0 as it requires PHP 8.1

@orklah orklah merged commit f327c98 into vimeo:master Nov 6, 2021
@orklah
Copy link
Collaborator

orklah commented Nov 6, 2021

Well, there's no issue running the CI on 8.1 to test real projects. However, we're based on a fork of psl so in any case, we won't always run against the most up-to-date branch anyway

@azjezz azjezz deleted the chore/update-psl branch November 6, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants