-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): update psl version used in e2e tests #6766
Conversation
38cf6a6
to
cba56b6
Compare
@orklah can i have write access to |
Thanks for that, I was a little lost. I don't have write permissions on it either. I'm gonna ask Matt. |
The issue was that phpbench isn't installed, but a file from it's source is referenced as extraFile in the configuration, i guess the error message could be improved, something like "configuration: unable to locate extra file 'path/to/file'", currently this is the error you get:
|
@azjezz just invited you to that repo |
Sorry @azjezz just realised I invited you to |
a5ad90c
to
2416266
Compare
2416266
to
9bd6289
Compare
Signed-off-by: azjezz <[email protected]>
rebased! |
PSL 2.0 has standard project structure, but i think we should wait before switching to 2.0 as it requires PHP 8.1 |
Well, there's no issue running the CI on 8.1 to test real projects. However, we're based on a fork of psl so in any case, we won't always run against the most up-to-date branch anyway |
closes #6706