Allow Symfony 6

[loic425]

No description provided.

[loic425]

@orklah I didn't see any configuration on your CI to test versions of Symfony.

[weirdan]

This is no-op until brianum/paratest allows newer symfony components:

[orklah]

unless I'm mistaken, there is no release made for 6.0 yet neither
https://github.com/symfony/console/releases
https://github.com/symfony/process/releases

And we can't allow dev branches.

This will have to wait november

[loic425]

@orklah Yes but Symfony encourages to be prepared as soon as possible and helping each third party packages to work on this before the release.

Moreover it will be released in a few weeks.

Some packages with Symfony 6 merged PR on main branch:

• Behat
• JmsSerializerBundle

[loic425]

@orklah Making this available on main branch allow third party packages to work on Symfony 6 support using your "dev-master".

[orklah]

I'm all for preparing and checking if it's okay. If possible, I'd like to have a CI running somewhere with symfony 6 just to check that we are ready but there are a few constraints:

• I don't know the release process of Symfony. Do they still commit on this branch? Is it possible they'll introduce a bug, a new bc break or a regression before release?
• Symfony/console:6.0 doesn't exists yet as a stable version. This is what happens when we try to require it: "Could not find package symfony/console in a version matching "6.0" and a stability matching "dev".", so adding it as-is won't have any effect
• We have dependencies ourselves that refuse symfony/console 6, those will have to be resolved first

So, if I summarize all this:
if we want to prepare for symfony 6, we have to have a CI job somewhere or a local execution that:

• allows devs packages
• don't have dependencies issues
• that will allow to really install symfony 6 so we can use our test suite against

If this outputs new errors, those will have to be fixed. If not, it means it means we'll be ready to add ^6.0 to our accepted versions when symfony will release their package.

If we don't do that, it means we'll release a version now where we accept a package that we didn't test again and that may still change until the release. This means, the day where symfony release the package and our own dependencies allows it, we'll possibly break builds using the release we made without the fixes needed.

So, if you want to help, what you need to do change your composer.json locally and add https://getcomposer.org/doc/04-schema.md#minimum-stability to "dev", https://getcomposer.org/doc/04-schema.md#prefer-stable to true, and try require symfony 6. Ideally, it would pass and really install symfony 6, unfortunately, our dependancies will block you, so you need to propose a PR to them too so they'll allow it. Either they'll accept the PR, or you need to target your PR branch from your local psalm's composer file.

Once you're able to really install symfony 6 through composer, you have to run our test suite to see if anything breaks. If it doesn't, great! Push your composer.json in this PR and once we can remove minimum-stability, prefer-stable from it, it means we're ready to merge

[orklah]

About behat, you'll note that's what they did here:
https://github.com/Behat/Behat/pull/1346/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R30

They introduced symfony 6 in their CI as a dev package to test against before merging.

[orklah]

@orklah Making this available on main branch allow third party packages to work on Symfony 6 support using your "dev-master".

If you have trouble installing Psalm along with other packages, you should use https://github.com/psalm/phar instead, it has no dependencies so it won't bother you with that

[orklah]

as we discussed, we need to have a full run of the test suite really using symfony 6 before we can merge

[loic425]

@orklah Yes, I agree with you. I will work on this soon.

[loic425]

@orklah I opened a PR on Paratest.

[loic425]

@orklah 😵‍💫
https://github.com/paratestphp/paratest/runs/4116716725?check_suite_focus=true

What's next? Do you advice Paratest to use the psalm phar instead?

[weirdan]

I didn't realize we had circular dependencies.

[weirdan]

I'd be ok with merging and releasing just range extension, without CI changes. Worst case scenario is we have psalm-plugin not working in some combination of Psalm and Symfony versions, and that's no big deal in my book.

I don't see a need to test compatibility with every Symfony version on every push.

[loic425]

I'd be ok with merging and releasing just range extension, without CI changes. Worst case scenario is we have psalm-plugin not working in some combination of Psalm and Symfony versions, and that's no big deal in my book.

I don't see a need to test compatibility with every Symfony version on every push.

I reverted the CI changes.