Fix false positives for UnusedIssueHandlerSuppression #11212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnusedIssueHandlerSuppression would be emitted for any issue handler rather than just suppressions. For example, this would trigger it, even if it was used: ``` <UndefinedClass errorLevel="info" /> ``` This fixes up an if statement so that the issue is only emitted for `errorLevel="suppress"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnusedIssueHandlerSuppressionwould be emitted for any issue handler rather than just suppressions.For example, this would trigger it, even if it was used:
This fixes up an if statement so that the issue is only emitted for
errorLevel="suppress".I tried writing a test for this change, but didn't find it very straightforward and settled for not writing one:
TestCasedoesn't have very good hooks for providing a custom configuration or issue handlers, though it is doable.IssueBuffer::finishdoesn't provide a way to inspect the final issues, except by capturing and parsing output (ob_start, etc.)Happy to receive feedback or advice on testing.