MissingDependency is reported even if guarded for said dependency

[ostrolucky]

https://psalm.dev/r/ba929c576a

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/ba929c576a

<?php

class Bar implements Foo {}

function takesAnInt(): void {
    if (!interface_exists(Foo::class)) {
        return;
    }
    
    new Bar();
}

Psalm output (using commit 6d45003):

ERROR: UndefinedClass - 6:27 - Class, interface or enum named Foo does not exist

INFO: MixedArgument - 6:27 - Argument 1 of interface_exists cannot be mixed, expecting string

ERROR: MissingDependency - 10:9 - Bar depends on class or interface foo that does not exist

ERROR: UndefinedClass - 3:22 - Class, interface or enum named Foo does not exist

[orklah]

Well, as far as Psalm can know, you guarded against a class that doesn't exists because you made a typo in the name and it's exactly what it wants to warn you about.

Or it could also be a case where it's just an issue with the autoloader provided to Psalm, which you also should be warned about.

I'd just suppress those, it's a pretty niche pattern that'd be hard to handle

[AndrolGenhald]

I do think though that the fact that interface_exists works differently than class_exists should be considered a bug.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/20b3f55d85

<?php

class Bar implements Foo {}

function takesAnInt(): void {
    if (!class_exists(Foo::class)) {
        return;
    }
    
    new Bar();
}

Psalm output (using commit 6d45003):

ERROR: MissingDependency - 10:9 - Bar depends on class or interface foo that does not exist

ERROR: UndefinedClass - 3:22 - Class, interface or enum named Foo does not exist

[orklah]

I'm fine with that :)

[AndrolGenhald]

@ostrolucky You also have to conditionally define the class (which is terrible for Psalm's analysis), because otherwise PHP will crash if it's autoloaded whether or not you construct it: https://3v4l.org/XZROZ

Conditionally defining does remove the MissingDependency issue though.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/5aff6f4584

<?php

if (interface_exists(Foo::class)) {
	class Bar implements Foo {}
} else {
    class Bar {}
}

function takesAnInt(): void {
    if (!interface_exists(Foo::class)) {
        return;
    }
    
    new Bar();
}

Psalm output (using commit 6d45003):

ERROR: UndefinedClass - 3:22 - Class, interface or enum named Foo does not exist

INFO: MixedArgument - 3:22 - Argument 1 of interface_exists cannot be mixed, expecting string

ERROR: UndefinedClass - 4:23 - Class, interface or enum named Foo does not exist

ERROR: UndefinedClass - 10:27 - Class, interface or enum named Foo does not exist

INFO: MixedArgument - 10:27 - Argument 1 of interface_exists cannot be mixed, expecting string