loose comparisons of int with string shouldn't change change the int …

…to empty-mixed
vimeo · Nov 21, 2023 · d94f7bd · d94f7bd
1 parent 5f0332b
commit d94f7bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Type/SimpleAssertionReconciler.php b/src/Psalm/Internal/Type/SimpleAssertionReconciler.php
@@ -1040,6 +1040,10 @@ private static function reconcileString(
                     $string_types[] = $type;
                 }
 
+                $redundant = false;
+            } elseif ($type instanceof TInt && $assertion instanceof IsLooselyEqual) {
+                // don't change the type of an int for non-strict comparisons
+                $string_types[] = $type;
                 $redundant = false;
             } else {
                 $redundant = false;

diff --git a/tests/TypeReconciliation/ConditionalTest.php b/tests/TypeReconciliation/ConditionalTest.php
@@ -1350,7 +1350,6 @@ function takes_string(string $string) : void {}
                     function takes_int(int $int) : void {}
 
                     if ($int == $string) {
-                        /** @psalm-suppress MixedArgument */
                         takes_int($int);
                     }',
             ],