don't emit redundant error when checking a named type against itself

vimeo · Oct 25, 2021 · caf9602 · caf9602
1 parent e334923
commit caf9602
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Type/AssertionReconciler.php b/src/Psalm/Internal/Type/AssertionReconciler.php
@@ -457,6 +457,9 @@ private static function refine(
             if ($key
                 && $code_location
                 && $new_type->getId() === $existing_var_type->getId()
+                //even if two objects are the same, equality is not guaranteed
+                // example: (ErrorException and TypeError are both Throwable but not equal)
+                && !$new_type->hasNamedObjectType()
                 && !$is_equality
                 && !($original_assertion === 'loaded-class-string' && $old_var_type_string === 'class-string')
                 && (!($statements_analyzer->getSource()->getSource() instanceof TraitAnalyzer)