Merge pull request #7089 from marcosh/abs-should-return-positive-int

vimeo · Dec 7, 2021 · a1b5e48 · a1b5e48
2 parents 2530b33 + 9c4187f
commit a1b5e48
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/stubs/CoreGenericFunctions.phpstub b/stubs/CoreGenericFunctions.phpstub
@@ -423,7 +423,7 @@ function gettimeofday(bool $as_float = false) {}
  * @psalm-pure
  *
  * @param numeric $num
- * @return ($num is int ? int : ($num is float ? float : int|float))
+ * @return ($num is int ? positive-int|0 : ($num is float ? float : positive-int|0|float))
  */
 function abs($num) {}
 

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -47,9 +47,9 @@ function fooFoo(array $a = []): void {
                     $c = $_GET["c"];
                     $c = is_numeric($c) ? abs($c) : null;',
                 'assertions' => [
-                    '$a' => 'int',
+                    '$a' => 'int|positive-int',
                     '$b' => 'float',
-                    '$c' => 'float|int|null',
+                    '$c' => 'float|int|null|positive-int',
                 ],
                 'error_levels' => ['MixedAssignment', 'MixedArgument'],
             ],