Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Laravel 7 #70

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Support for Laravel 7 #70

merged 1 commit into from
Mar 6, 2020

Conversation

jasonmccreary
Copy link
Contributor

This adds support for Laravel 7, while maintaining support for previous versions.

It overwrites the ^6.2 constraint as it was redundant given the ^6.0 constraint.

@muglug muglug merged commit 2271eef into vimeo:master Mar 6, 2020
@muglug
Copy link
Contributor

muglug commented Mar 6, 2020

Thanks!

@ajoy39
Copy link

ajoy39 commented Mar 6, 2020

Unfortunately it looks like tus-php has symphony console locked to version 4 or below and Laravel 7 requires 5, so nothing you can really do about that

@jasonmccreary
Copy link
Contributor Author

jasonmccreary commented Mar 6, 2020

They have a symfony5 branch. The vimeo-api package will need to be updated. Or you can in your own composer.json.

"tus-php": "dev-symfony5 as 1.0"

As it stands though, this PR is accurate for this package. Unfortunately, now we wait on the upstream packages to support the requirements of Laravel 7.

@jasonmccreary jasonmccreary deleted the patch-1 branch March 6, 2020 02:56
@jasonmccreary jasonmccreary restored the patch-1 branch March 6, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants