Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Psalm and add necessary typehints #47

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add Psalm and add necessary typehints #47

merged 1 commit into from
Mar 4, 2019

Conversation

muglug
Copy link
Contributor

@muglug muglug commented Mar 4, 2019

Psalm now has a Laravel plugin, used here.

@muglug muglug requested a review from erunion March 4, 2019 17:53
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2019

CLA assistant check
All committers have signed the CLA.

"phpunit/phpunit": "^7.0"
"phpunit/phpunit": "^7.0",
"psalm/plugin-laravel": "^0.1",
"zendframework/zend-diactoros": "1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's using this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required for Laravel IDE Helper to avoid complaints about missing packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not actually, PR incoming...

@erunion erunion merged commit c02e884 into master Mar 4, 2019
@erunion erunion deleted the add-psalm branch March 4, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants