Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Dsys 5 slider number input #339

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Dsys 5 slider number input #339

merged 4 commits into from
Aug 15, 2023

Conversation

nathanbrud
Copy link
Collaborator

@nathanbrud nathanbrud commented Aug 15, 2023

What this PR does

Adds UI for arrows up/down for the slider editable input

Screenshots & Recordings

Screen.Recording.2023-08-15.at.13.30.56.mov

How it does that

  • Separate the EditableInput into a component
  • Added Arrows component
  • Handle click up/down logic

Testing

  • Hover editable input in the slider
  • See arrows up and down
  • Click on them and see value is changing

@nathanbrud nathanbrud marked this pull request as ready for review August 15, 2023 11:03
@nathanbrud nathanbrud requested review from a team as code owners August 15, 2023 11:03
@nathanbrud nathanbrud self-assigned this Aug 15, 2023
Set fill as currentColor
@nathanbrud nathanbrud force-pushed the DSYS-5-slider-number-input branch from e50fa95 to 1fabd80 Compare August 15, 2023 14:57
@nathanbrud nathanbrud temporarily deployed to development August 15, 2023 15:30 — with GitHub Actions Inactive
@nathanbrud nathanbrud merged commit 4538b56 into main Aug 15, 2023
@nathanbrud nathanbrud deleted the DSYS-5-slider-number-input branch August 15, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants