Skip to content

Commit

Permalink
Merge pull request #495 from vimc/vimc-7432
Browse files Browse the repository at this point in the history
vimc-7432 Update guidance for 2024 Rfp touchstone
  • Loading branch information
EmmaLRussell authored Sep 27, 2024
2 parents 510a1b3 + 78479ac commit e912f9e
Show file tree
Hide file tree
Showing 10 changed files with 65 additions and 29 deletions.
22 changes: 11 additions & 11 deletions app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/scripts/clear-docker.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
docker stop $(docker ps -aq)
docker rm $(docker ps -aq) -f
docker network prune --force
docker volume prune --force

docker ps
1 change: 1 addition & 0 deletions app/scripts/montagu-api.config.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
orderlyweb.api.url=http://montagu-orderly_web-1:8888/api/v2
18 changes: 10 additions & 8 deletions app/scripts/run-dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,21 @@ docker run -v $ROOT/demo:/orderly $OW_CLI_IMAGE add-users [email protected]
docker run -v $ROOT/demo:/orderly $OW_CLI_IMAGE grant [email protected] */users.manage

# Run the APIs and database
docker-compose pull
docker-compose --project-name montagu up -d
docker compose pull
docker compose --project-name montagu up -d

# Start the APIs
docker exec montagu_api_1 mkdir -p /etc/montagu/api/
docker exec montagu_api_1 touch /etc/montagu/api/go_signal
# Wait for the database
docker exec montagu_db_1 montagu-wait.sh
docker exec montagu-api-1 mkdir -p /etc/montagu/api/
docker container cp $here/montagu-api.config.properties montagu-api-1:/etc/montagu/api/config.properties
docker exec montagu-api-1 touch /etc/montagu/api/go_signal

# Wait for the database - this can take a while on buildkite
docker exec montagu-db-1 montagu-wait.sh 300

# Migrate the database
docker pull $MONTAGU_MIGRATE_IMAGE
docker run --network=montagu_default $MONTAGU_MIGRATE_IMAGE

#start orderly web
docker exec montagu_orderly_web_1 mkdir -p /etc/orderly/web
docker exec montagu_orderly_web_1 touch /etc/orderly/web/go_signal
docker exec montagu-orderly_web-1 mkdir -p /etc/orderly/web
docker exec montagu-orderly_web-1 touch /etc/orderly/web/go_signal
6 changes: 3 additions & 3 deletions app/scripts/run-integration-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export PGPORT=5432
# script

# Setup template database
docker exec montagu_db_1 psql -U vimc -d postgres -c \
docker exec montagu-db-1 psql -U vimc -d postgres -c \
"ALTER DATABASE $PGDATABASE RENAME TO $PGTEMPLATE"

# Run the tests
Expand All @@ -27,8 +27,8 @@ result=$?

# ------- Teardown -----------
# Restore the database
docker exec montagu_db_1 psql -U vimc -d postgres -c \
docker exec montagu-db-1 psql -U vimc -d postgres -c \
"ALTER DATABASE $PGTEMPLATE RENAME TO $PGDATABASE"

docker logs montagu_api_1 > api.log 2> api.log
docker logs montagu-api-1 > api.log 2> api.log
exit $result
4 changes: 2 additions & 2 deletions app/scripts/stop-dependencies.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash
set -ex
docker-compose --project-name montagu down --volumes
docker-compose --project-name montagu rm
docker compose --project-name montagu down --volumes
docker compose --project-name montagu rm
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ interface ResponsibilityOverviewDescriptionProps {
touchstoneStatus: string;
}

const rfp2024Guidance = require('./rfp-2024-guidance.pdf');

const ContactDetails = () => {
return <div>
If you have any questions about using Montagu, please email&nbsp;
Expand Down Expand Up @@ -68,8 +70,26 @@ const TwentyTwentyTwoRfpTouchstone = () => {
We have named the anonymous pre-defined country 'RfP'.
</p>
<p>
Output specifications guidance is available within the Guide for Applicants. To access this, go to&nbsp;
<a href="https://www.vaccineimpact.org/2022-11-23-rfp/">https://www.vaccineimpact.org/2022-11-23-rfp/</a>.
Output specifications guidance is available within the Guide for Applicants. To access this, go to&nbsp;
<a href="https://www.vaccineimpact.org/2022-11-23-rfp/">https://www.vaccineimpact.org/2022-11-23-rfp/</a>.
</p>
<ContactDetails/>
</div>
};

const TwentyTwentyFourRfpTouchstone = () => {
return <div>
On this page you can:
<ul>
<li>Access standardised demographic data for the anonymous pre-defined country.</li>
<li>Download the burden estimate templates for your disease area.</li>
<li>Submit the burden estimates generated by your model, for the pre-defined country.</li>
</ul>
<p>
We have named the anonymous pre-defined country 'RfP'.
</p>
<p>
Output specifications guidance is available within the <a href={rfp2024Guidance}>Guide for Applicants</a>.
</p>
<ContactDetails/>
</div>
Expand All @@ -90,8 +110,11 @@ export const ResponsibilityOverviewDescription = (props: ResponsibilityOverviewD
if (props.currentTouchstoneId.indexOf("2020") > -1) {
return TwentyTwentyRfpTouchstone()
}
else {
if (props.currentTouchstoneId.indexOf("2019") > -1) {
return TwentyNineteenRfpTouchstone()
} else
{
return TwentyTwentyFourRfpTouchstone()
}
} else {
let guidanceInputsUrl = `/help/model-inputs/${props.currentTouchstoneId}`;
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ describe("Responsibility Overview Description Component", () => {
});

it("renders component for 2019 applicants touchstone", () => {
const rendered = shallow(<ResponsibilityOverviewDescription currentTouchstoneId={itTouchstoneId2} groupId={itGroupId} touchstoneStatus={touchstoneStatus}/>);
const touchstoneId = "2019rfp-1";
const rendered = shallow(<ResponsibilityOverviewDescription currentTouchstoneId={touchstoneId} groupId={itGroupId} touchstoneStatus={touchstoneStatus}/>);
expect(rendered.text().indexOf("Access the standardised demographic") > -1).toEqual(true);
});

Expand All @@ -38,6 +39,14 @@ describe("Responsibility Overview Description Component", () => {
expect(rendered.text().indexOf("https://www.vaccineimpact.org/2022-11-23-rfp")).toBeGreaterThan(-1);
});

it("renders component for 2024 applicants touchstone", () => {
const touchstoneId = "202410rfp-1";
const rendered = shallow(<ResponsibilityOverviewDescription currentTouchstoneId={touchstoneId} groupId={itGroupId} touchstoneStatus={touchstoneStatus}/>);
expect(rendered.text().indexOf("the anonymous pre-defined country")).toBeGreaterThan(-1);
expect(rendered.text().indexOf("Output specifications guidance is available within the Guide for Applicants")).toBeGreaterThan(-1);
expect(rendered.html().indexOf("/rfp-2024-guidance.pdf")).toBeGreaterThan(-1);
});

it("renders component on touchstone is not open", () => {
const rendered = shallow(<ResponsibilityOverviewDescription currentTouchstoneId={itTouchstoneId2} groupId={itGroupId} touchstoneStatus="finished"/>);
expect(rendered.text().indexOf("This touchstone is no longer open")).toBeGreaterThan(-1);
Expand Down
2 changes: 1 addition & 1 deletion config/orderlyweb/config.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
montagu.api_url=http://montagu_api_1:8080/v1
montagu.api_url=http://montagu-api-1:8080/v1

0 comments on commit e912f9e

Please sign in to comment.