avoid paramsSolver::{n_rows,n_cols} shadowing their base class counte…

…rparts (rapidsai#4130) This looks to me like a typo, and may be problematic and confusing if the `n_rows` and `n_cols` members from the base class instead of the ones from the derived class are accessed. Signed-off-by: Yitao Li <[email protected]> Authors: - Yitao Li (https://github.com/yitao-li) Approvers: - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4130
vimarsh6739 · Sep 14, 2021 · c5af612 · c5af612
1 parent 88add9d
commit c5af612
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/cpp/include/cuml/decomposition/params.hpp b/cpp/include/cuml/decomposition/params.hpp
@@ -38,8 +38,6 @@ class params {
 
 class paramsSolver : public params {
  public:
-  int n_rows;
-  int n_cols;
   // math_t tol = 0.0;
   float tol        = 0.0;
   int n_iterations = 15;